fix: remove dead SchemaMigrationService and unused Migration entity - #1377
Merged
RUKAYAT-CODER merged 1 commit intoAug 29, 2026
Merged
Conversation
SchemaMigrationService and the schema_migrations table were never wired up — no module registered the service, no migration created the table, and no code imported the Migration entity. They only sat in the migrations directory, where TypeORM's migration glob had to be explicitly configured to ignore them. Closes rinafcode#1199 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
SchemaMigrationService, theMigrationentity, and theentities/directory — all dead code that was never wired up.Closes
Closes #1199
Changes
src/migrations/schema-migration.service.tssrc/migrations/entities/migration.entity.tssrc/migrations/entities/src/config/datasource.tsWhy
SchemaMigrationServicequeries and inserts into aschema_migrationstable, but:migrationstable.Migrationentity — zero references across the entiresrc/directory.The service and entity only sat in the
src/migrations/directory, where the TypeORM migration glob indatasource.tshad to be explicitly configured to ignore them (via the[0-9]*timestamp prefix pattern). This makes the code misleading and a maintenance burden.Verification
tsc --noEmitpasses with no errorsnest buildsucceeds